Skip to content

Conditional aux halo exchange via aux-field flag#55

Merged
haraldkl merged 7 commits intomainfrom
aux-exchange-conditional-oldbase
Feb 28, 2026
Merged

Conditional aux halo exchange via aux-field flag#55
haraldkl merged 7 commits intomainfrom
aux-exchange-conditional-oldbase

Conversation

@MikeW097
Copy link
Copy Markdown
Member

@MikeW097 MikeW097 commented Feb 25, 2026

Based on the discussion in #53, the main goal of this update is to keep the existing interfaces unchanged to avoid unintended downstream effects in ApesMate while still enabling conditional auxiliary halo communication.

@haraldkl
Copy link
Copy Markdown
Member

I'd prefer it if we could set the flag in the init routine of auxfield, that is we amend that one interface, but the others wouldn't need it anymore. This way the initialization of the type is not spread across multiple parts of the code (hopefully).

@MikeW097
Copy link
Copy Markdown
Member Author

MikeW097 commented Feb 26, 2026

@haraldkl the tracking is currently initialized after the auxfield, so needHaloComm is determined later based on the selected tracking. would you be OK with a two-step auxfield initialization: init_aux sets defaults, and then a single auxfield_configure_from_tracking (still within auxfield module) sets needHaloComm once after tracking is known?

@haraldkl
Copy link
Copy Markdown
Member

Yes, though in that case it isn't that important, I still think it would be preferable to have function there setting the flag, rather than setting the flag directly.

@MikeW097 MikeW097 marked this pull request as ready for review February 27, 2026 02:58
@MikeW097
Copy link
Copy Markdown
Member Author

@haraldkl I’ve updated the implementation accordingly by introducing auxfield_configure_from_tracking to set the flag.
Could you please take another look and let me know if this aligns with your expectations?

@haraldkl
Copy link
Copy Markdown
Member

@MikeW097 I did some formatting. Please pull. Would you mind adding your copyright line in the top of the files where you added code? Otherwise that's fine to merge from my point of view. Thanks a lot!

@MikeW097
Copy link
Copy Markdown
Member Author

@haraldkl Thanks for the review and formatting fixes. I’ve added the copyright line to the files I modified.

Copy link
Copy Markdown
Member

@haraldkl haraldkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again @MikeW097.

@haraldkl haraldkl merged commit 81f8c4f into main Feb 28, 2026
@haraldkl haraldkl deleted the aux-exchange-conditional-oldbase branch February 28, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants